Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset trigger extension and wildcards #10

Closed
guybedford opened this issue Mar 22, 2019 · 3 comments
Closed

Asset trigger extension and wildcards #10

guybedford opened this issue Mar 22, 2019 · 3 comments

Comments

@guybedford
Copy link
Contributor

From the bug report at https://spectrum.chat/zeit/now/reading-template-assets-on-file-system-using-now-node~56f167d9-7416-444f-a352-6738b341df48, we should be able to support the following pattern:

const template_location = process.cwd() + '/api/email-templates/' + template_name + name + '.html';

That is:

  1. Supporting process.cwd() as a trigger for expression analysis
  2. Supporting wildcards in the analysis
  3. Supporting wildcards in the emission process
@styfle
Copy link
Member

styfle commented Mar 22, 2019

Yes please! 💚

@guybedford
Copy link
Contributor Author

process.cwd() is actually quite tricky because we don't what it is!

What we can do here is permit process.cwd() as a build option, then in ncc itself pass the build process.cwd() to this. It still seems a little fragile, but likely the best we can do.

@guybedford
Copy link
Contributor Author

These features are now all implemented in #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants