Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

feat: add browser features to browse by version #125

Merged
merged 8 commits into from Sep 1, 2019

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Aug 31, 2019

Type: feat

Description:

Add version browsing capabilities per version

Screen Shot 2019-08-31 at 1 23 03 PM

Resolve: https://github.com/verdaccio/ui/issues/109

@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #125 into master will decrease coverage by 0.11%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   84.25%   84.14%   -0.12%     
==========================================
  Files          92       92              
  Lines         902      927      +25     
  Branches      160      151       -9     
==========================================
+ Hits          760      780      +20     
- Misses        126      132       +6     
+ Partials       16       15       -1
Impacted Files Coverage Δ
src/router.tsx 82.35% <ø> (ø) ⬆️
src/utils/calls.ts 75% <100%> (ø) ⬆️
src/components/DetailSidebar/DetailSidebar.tsx 89.47% <75%> (-10.53%) ⬇️
src/pages/Version/Version.tsx 87.5% <75%> (-9.65%) ⬇️
src/components/Versions/Versions.tsx 89.47% <91.66%> (+22.8%) ⬆️
src/components/Header/Header.tsx 89.47% <0%> (ø) ⬆️
src/components/Install/Install.tsx 83.33% <0%> (ø) ⬆️
...mponents/RegistryInfoDialog/RegistryInfoDialog.tsx 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec54d...3874954. Read the comment docs.

@juanpicado juanpicado removed the wip label Sep 1, 2019
@juanpicado juanpicado added this to the candidate for next release milestone Sep 1, 2019
@juanpicado juanpicado merged commit 1904179 into master Sep 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-add-version-page branch September 1, 2019 11:09
@kishok
Copy link

kishok commented Sep 5, 2019

Hi juanpicado,

      Version Link not showing the corresponding link readMe , dependencies and tarball zip. please check this and provide fix asap. 

@juanpicado
Copy link
Member Author

Please explain you better, I don't know what you mean.

please check this and provide fix asap.

About this, please be nice, remember this is FOSS, ASAP word cannot be used on this project.

@kishok
Copy link

kishok commented Sep 6, 2019

sorry i didn't mean anything to take it as serious but we are awaiting for this feature long before requested in this issue #1079.i know this project is helpful for our local npm repository.i will change the way i mentioned earlier.

thank you
juanpicado

@juanpicado
Copy link
Member Author

Hi @kishok about that feature, please check my comment here verdaccio/verdaccio#1079 (comment)
We don't store the README for all versions, for performance reasons, perhaps in the future we change that, but, this PR is just the beginning of it I guess.

Things move slow since we do this in our spare time, so patience is necessary for all of us. Things will come, soon or later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants