Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: correctly load font files - closes #128 #134

Merged
merged 2 commits into from Sep 29, 2019
Merged

fix: correctly load font files - closes #128 #134

merged 2 commits into from Sep 29, 2019

Conversation

DanielRuf
Copy link
Contributor

Type:
bug

Description:
This should fix the wrong paths for the Roboto fonts.

Resolves #128

juanpicado
juanpicado previously approved these changes Sep 29, 2019
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 perfect as always 👌

@juanpicado
Copy link
Member

@DanielRuf there is an issue https://app.circleci.com/jobs/github/verdaccio/ui/1551 could you check?

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Sep 29, 2019

I will have to check that in the react testing library repo as it seems they have an issue when it is not explicitely loaded as css file (extension).

@DanielRuf
Copy link
Contributor Author

See KyleAMathews/typefaces#113

@juanpicado
Copy link
Member

Thanks daniel !

@juanpicado juanpicado merged commit f61913c into verdaccio:master Sep 29, 2019
@DanielRuf DanielRuf deleted the fix/128-correctly-load-font-files branch September 29, 2019 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants