Header Component - Replaced class by func. comp #142
Conversation
priscilawebdev
added
good first issue
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 83.77% 85.06% +1.28%
==========================================
Files 99 107 +8
Lines 937 924 -13
Branches 161 160 -1
==========================================
+ Hits 785 786 +1
+ Misses 138 124 -14
Partials 14 14
Continue to review full report at Codecov.
|
priscilawebdev
changed the title
|
Your last PR conflicts with this one f84fd79#diff-2780c4d0882ad10abae71aa33af34c7b |
|
+1% coverage 🥰 good job 👏🏻 |
| ); | ||
|
|
||
| expect(container.firstChild).toMatchSnapshot(); | ||
| expect(queryByTestId('header--menu-acountcircle')).toBeNull(); |
There was a problem hiding this comment.
Reminder, the test-id is fine for me, but, according the guidelines, should be the 3rd option.
delete-merged-branch
bot
deleted the
refactor/130_convert_class_to_func_header
branch
|
This commit had the unintended consequence of breaking the plugin Not sure what the fix here is. Add the id's back to modify the plugin to look for the id's in Issue to track is here: n4bb12/verdaccio-github-oauth-ui#39 |
Type: Refactor
The following has been addressed in the PR: https://github.com/verdaccio/ui/issues/116
Unit or Functional tests are included in the PR?
Yes.
Description:
in order to use react hooks, in this PR I updated the Header component by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.