This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
CircularProgress Component - Introduced ForwardRef #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 88.15% 88.18% +0.02%
==========================================
Files 107 108 +1
Lines 912 914 +2
Branches 163 147 -16
==========================================
+ Hits 804 806 +2
- Misses 94 95 +1
+ Partials 14 13 -1
Continue to review full report at Codecov.
|
tmkn
reviewed
Oct 11, 2019
| import React, { forwardRef } from 'react'; | ||
| import { default as MaterialUICircularProgress, CircularProgressProps } from '@material-ui/core/CircularProgress'; | ||
|
|
||
| type CircularProgressRef = HTMLElementTagNameMap['div']; |
There was a problem hiding this comment.
Why not just use HTMLDivElement directly?
There was a problem hiding this comment.
Yeah, good idea :-) Thanks!
tmkn
previously approved these changes
Oct 11, 2019
juanpicado
approved these changes
Oct 12, 2019
delete-merged-branch
bot
deleted the
refactor/162_introduced_forward_ref_circular_progress
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #162
Unit or Functional tests are included in the PR? Not yet
Description:
Wrapped Material UI CirularProgress Component with ForwardRef