Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplink connection timeout returns incorrect status code #1328

Closed
ianschmitz opened this issue May 29, 2019 · 3 comments
Closed

Uplink connection timeout returns incorrect status code #1328

ianschmitz opened this issue May 29, 2019 · 3 comments
Assignees
Milestone

Comments

@ianschmitz
Copy link

This issue may be related to #720.

Describe the bug
We discovered this issue while porting create-react-app over to Azure DevOps build pipeline (facebook/create-react-app#7096). If a connection to the uplink (e.g. registry.npmjs.org) times out, Verdaccio returns a 404 status code, which causes the npm/yarn client to fail.

Expected behavior
Verdaccio should return a 503 status code which tells the npm/yarn client to try again.

@willsmythe helped us fix this in a fork of his. You can see the diff here: master...willsmythe:fix-404-on-uplink-timeout.

@juanpicado
Copy link
Member

Thanks @ianschmitz the commit provided have really interesting things, I'll check it myself.

@willsmythe
Copy link
Contributor

I just pushed a few updates to my branch and will open a PR so we can discuss the changes.

@lock
Copy link

lock bot commented Sep 11, 2019

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot added the outdated label Sep 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants