feat: ensure every log file has at least one record

[mlucool]

Type: feature

The following has been addressed in the PR:
Description:
Sometimes logs are empty if no one tries to access verdaccio. This is especially with logrotate where no one may access it over a period of time. This commit ensures every log has at least one message in it (assuming warn or above level of logging).

[juanpicado]

I will check it later, but, I am rethinking about file rotation in the next major release next year and remove such support. Thoughts ?

[mlucool]

Why would you want to remove that? IMO, it's a great and useful feature!

This issue comes up without file rotate also, hence the Verdaccio started log statement.

[juanpicado]

There is a issue, the message get printed twice on startup with the default config.

[mlucool]

There is a issue, the message get printed twice on startup with the default config.

Not sure if that's a bug. The issue is that in the default logging, we call setup twice and both happen to output to the same place (console). First in cli.ts then in index.ts. In theory these are different logs. I can add something to make cli.js not add this output if you think that's cleaner.

[juanpicado]

Not sure if that's a bug. The issue is that in the default logging, we call setup twice and both happen to output to the same place (console). First in cli.ts then in index.ts. In theory these are different logs. I can add something to make cli.js not add this output if you think that's cleaner.

It is a design decision by my predecesor. Since we have this in in progress #1334 I wouldn't no change that. I'll add it to the check list, but better don't do it in this PR. Logger will change soon or later, I agree there are pitfalls like that one you described.

[mlucool]

So what should we do to move this forward?

[juanpicado]

I was waiting your comments, but we need to remove logger.warn('Verdaccio started'); (one of them), since it pops up twice and does not look good in the terminal.

[mlucool]

The above comment has been fixed

[mlucool]

Is there anything else that should be fixed?

[juanpicado]

hi @mlucool I could not test it yet, completely forgot it. perhaps cc: @verdaccio/collaborators can help checking this to ship it asap, or maybe me a long the week.

[juanpicado]

👍 now works fine 👍

 warn --- config file  - /Users/xxxx/.config/verdaccio/config.yaml
 warn --- Verdaccio started
 warn --- Plugin successfully loaded: verdaccio-htpasswd
 warn --- Plugin successfully loaded: verdaccio-audit
 warn --- http address - http://localhost:4873/ - verdaccio/4.2.2

[lock]

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘