Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use https to resolve mixed content errors #1674

Merged
merged 2 commits into from Jan 15, 2020
Merged

fix: use https to resolve mixed content errors #1674

merged 2 commits into from Jan 15, 2020

Conversation

DanielRuf
Copy link
Contributor

Type:
fix

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

This PR resolves the mixed content errors that we can see on https://npmjs.com/verdaccio

Bildschirmfoto 2020-01-12 um 17 35 00

@DanielRuf DanielRuf requested review from a team January 12, 2020 16:36
@juanpicado
Copy link
Member

I think other repos might have the same issue

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #1674 into master will increase coverage by 0.02%.
The diff coverage is 81.03%.

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   84.92%   84.95%   +0.02%     
==========================================
  Files          47       47              
  Lines        2481     2479       -2     
  Branches      572      571       -1     
==========================================
- Hits         2107     2106       -1     
+ Misses        370      369       -1     
  Partials        4        4
Impacted Files Coverage Δ
src/api/middleware.ts 79.68% <0%> (ø) ⬆️
src/api/endpoint/api/v1/profile.ts 87.5% <0%> (ø) ⬆️
src/lib/logger/formatter.ts 93.1% <100%> (ø) ⬆️
src/lib/storage.ts 78.77% <100%> (ø) ⬆️
src/lib/notify/index.ts 100% <100%> (ø) ⬆️
src/utils/user.ts 100% <100%> (+11.11%) ⬆️
src/api/endpoint/api/star.ts 81.25% <100%> (ø) ⬆️
src/lib/utils.ts 93.98% <100%> (ø) ⬆️
src/lib/notify/notify-request.ts 100% <100%> (ø) ⬆️
src/api/web/endpoint/package.ts 74.13% <100%> (ø) ⬆️
... and 4 more

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juanpicado juanpicado merged commit fd6c649 into verdaccio:master Jan 15, 2020
@juanpicado
Copy link
Member

Thanks @DanielRuf !!

@lock
Copy link

lock bot commented Jan 25, 2020

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2020
@DanielRuf DanielRuf deleted the fix/use-https branch April 4, 2020 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants