fix: incorrect primary_color crash the ui #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
verdacciobot
approved these changes
Apr 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 83.49% 83.47% -0.02%
==========================================
Files 48 48
Lines 2532 2536 +4
Branches 585 593 +8
==========================================
+ Hits 2114 2117 +3
Misses 414 414
- Partials 4 5 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
If the color is wrong, the UI crash
The hex color representation must be exact, otherwise, it returns to default. Material-UI only supports hex colors and RGB.