Refactor: move BodyParser to upper level #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 48 48
Lines 2537 2537
Branches 586 594 +8
=======================================
Hits 2117 2117
+ Misses 416 415 -1
- Partials 4 5 +1
|
juanpicado
reviewed
Jun 17, 2020
There was a problem hiding this comment.
Thanks @hydra13 looks good to me, but I will run a few tests before the merge.
|
Sure! Could you share the results of your test? |
|
Kudos, SonarCloud Quality Gate passed!
|
Are running 🙃 ... 3 new acceptant test running in 3 different package managers using latest changes. You can check the latest master commit. I guess that's good enough for me if they pass (still running) |
juanpicado
approved these changes
Jun 18, 2020
Closed
juanpicado
added a commit
that referenced
this pull request
Jul 16, 2020
This reverts commit 67c31b6
juanpicado
added a commit
that referenced
this pull request
Jul 16, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful when the middleware plugin has to get access to the request's body.
I tried to make publication and add some field "on the fly" and didn't get access to the request's body. (link to my example plugin)
The reason for this problem was that body-parser was used in
src/api/endpoint/index.tsand middleware plugins registered before ones.My PR just moves the call of body-parser from
src/api/endpoint/index.tstosrc/api/index.ts(above registration middleware plugins)