feat: allow scopes in loading plugins

[IhToN]

Describe the bug
Verdaccio is not able to load @verdaccio/active-directory plugin when using the config setup from the documentation.

To Reproduce
Install @verdaccio/active-directory
Set the proper config file
Retrieve error: verdaccio-activedirectory plugin not found. try "npm install verdaccio-activedirectory"

Expected behavior
Get the plugin to load

If we install the verdaccio-activedirectory package it works as intended, it looks like Verdaccio is not able to load or retrieve the plugin from the @verdaccio scope.

[sergiohgz]

Sorry, at the moment, Verdaccio is not able to load plugins whose name is @verdaccio/plugin-name. This is a feature we are planning

[IhToN]

Thanks for the answer. We will stay with the old package for now =)

[juanpicado]

On the roadmap ;-) @IhToN

Could be added to 4.x if someones pick it up.

[IhToN]

After some after-work investigations I found that it was possible to reference the plugin name directly on the config.yaml file, example:

auth:
  '@verdaccio/active-directory':

In any case I've added a new condition after verdaccio- and sinopia- prefixes it'll try to load @verdaccio/ prefix.

It also changes the Plugin successfully loaded message to follow this structure:
Plugin successfully loaded: @verdaccio/active-directory || From: locally installed plugin

From can be: external plugin folder, locally installed plugin and config folder

[juanpicado]

@IhToN one suggestion, this is something I've been thinking for a while .. what if .... the prefix is configurable ... ? I mean, nobody could publish under verdaccio scope at npmjs, so the feature would have limited use cases.

I'd suggest a new configuration parameter:

plugin_prefix: 'whatever` 

Then we could override the default here:

export default function loadPlugin<T extends IPlugin<T>>(
  config: Config,
  pluginConfigs: any = {},
  params: any,
  sanityCheck: any,
  prefix: string = 'verdaccio'
): any[] {

That will solve your issue and you wouldn't have to do this

auth:
  '@verdaccio/active-directory':

rather a default configuration

plugin_prefix: '@verdaccio` 
auth:
  active-directory:

This scalable for private plugins :) for all needs.

what do you think?

[IhToN]

@juanpicado That would be another possibility but then we would still have the struggle that it may be that different plugins have different prefixes.

If we have the packages

@verdaccio/active-directory
verdaccio-htpasswd
@foo/bar
@zoo/bar
@joo/bar

the problem will persist, and for the end user it will be simplier just to use the full plugin name.

The way it is right now it's kind of a way to have "official" plugins (@verdaccio/, verdaccio- and sinopia-) and it would still let the end user include an infinite amount of plugins wihtout problems.

It may be needed to document properly how the plugin loading works though.

[stale]

Hi pal 👋🏼!
This issue has gone quiet 😶.

We get a lot of issues, so we currently close issues after 180 days of inactivity. It’s been at least 90c days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add/suggest the label "discuss" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out https://github.com/verdaccio/contributing for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Verdaccio community! 💘

[juanpicado]

A workaround for this is here using Docker https://github.com/xlts-dev/verdaccio-prometheus-middleware#installation

[juanpicado]

#3227