-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: url_prefix behaviour #2122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2021
9d2d9c7
to
fb6c439
Compare
This was referenced Mar 17, 2021
fb6c439
to
c23d831
Compare
This was referenced Mar 23, 2021
This was referenced Mar 24, 2021
Closed
Closed
67a10bf
to
0305826
Compare
0305826
to
93b46bd
Compare
verdacciobot
previously approved these changes
Mar 29, 2021
a1997cb
to
79ccb54
Compare
verdacciobot
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url_prefix
featureThis fix is based on #2070 for the next major, but I plan to move some fix to the
v4
so we can solve this situation with no breaking changes.Scheduled release: next minor
url_prefix
The new internal logic builds correctly the public url, validates the
host
header and and bad shapedurl_prefix
.eg:
url_prefix: /verdaccio
,url_prefix: verdaccio/
,url_prefix: verdaccio
would be/verdaccio/
Public URL
The new
VERDACCIO_PUBLIC_URL
is intended to be used behind proxies, this variable will be used for:dist
base pathhost
andX-Forwarded-Proto
headersurl_prefix
is defined would be appened to the env variable.Custom favicon
The favicon can be replaced in 2 ways:
Local absolute path
By URL
If the logo is not defined, will fetch (and bundled in) the custom verdaccio favicon
UI
Web new properties for dynamic template
The new set of properties are made in order allow inject html and JavaScript scripts within the template. This
might be useful for scenarios like Google Analytics scripts or custom html in any part of the body.
head
element.body
element.