Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scoped plugin packages #3047

Closed
kuoruan opened this issue Mar 8, 2022 · 4 comments
Closed

Add support for scoped plugin packages #3047

kuoruan opened this issue Mar 8, 2022 · 4 comments

Comments

@kuoruan
Copy link
Contributor

kuoruan commented Mar 8, 2022

Is your feature request related to a problem?
No

Describe the solution you'd like
Add support for scoped package (eg. @google/verdaccio-google-auth-ui) as the plugin package name.

Describe alternatives you've considered
The config can be like:

auth:
  google-auth-ui@google:
    foo: bar

or:

auth:
  google-auth-ui:
    _scope: google # add prefix underline
    foo: bar

Leave blank can compatible with plugin named verdaccio-google-auth-ui

@edclement
Copy link
Collaborator

Maybe the below link will be helpful for you until something like what you're proposing is implemented. This is how we handle installing our plugin which is scoped under @xlts.dev.

https://github.com/xlts-dev/verdaccio-prometheus-middleware#installation

@juanpicado
Copy link
Member

There was a first try already #1868

@juanpicado
Copy link
Member

Second try #1868 (comment)
PR: #3227

@juanpicado juanpicado added this to the 5.x milestone Jun 14, 2022
@juanpicado juanpicado added this to Needs triage in Verdaccio Stable via automation Jun 14, 2022
@juanpicado juanpicado self-assigned this Jun 14, 2022
@juanpicado
Copy link
Member

juanpicado commented Jun 14, 2022

From v5.12.0 would be like this #3227

middlewares:
  audit:
    enabled: true
  '@xlts.dev/verdaccio-prometheus-middleware':
      metricsPath: /custom/path/metrics    

Verdaccio Stable automation moved this from Needs triage to Closed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants