Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add a config item to web,let the developer can select whether enable the html cache #3110

Merged
merged 5 commits into from Apr 11, 2022

Conversation

Tiny-Fendy
Copy link
Contributor

This is a new PR related to #3108.

@Tiny-Fendy
Copy link
Contributor Author

Tiny-Fendy commented Apr 8, 2022

The website has been archived, I can't update the documentation for this change.

@juanpicado
Copy link
Member

The website has been archived, I can't update the documentation for this change.

You can change the docs file directly on this #3108

It´s a bit confusing, the master branch refers to next major (v6), but also deploys the website (which refers to v5) eventually both will be alinged when v6 is released, but at this point is like this.

cache.set('template', webPage);
if (needHtmlCache) {
cache.set('template', webPage);
}
debug('set template cache');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include debug debug('set template cache'); within the if condition otherwise is missleading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,I have committed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've took the liberty to apply some small changes, add suggestion to the config files and just moved your new line to the header of the function close to the other configs, maybe you can apply same change son the other PR.

@juanpicado juanpicado changed the title Add a config item to web,let the developer can select whether enable the html cache feat(web): add a config item to web,let the developer can select whether enable the html cache Apr 11, 2022
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great stuff @Tiny-Fendy it will be on next minor

@juanpicado
Copy link
Member

Failed checks are unrelated with this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants