New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add a config item to web,let the developer can select whether enable the html cache #3110
Conversation
The website has been archived, I can't update the documentation for this change. |
You can change the docs file directly on this #3108 It´s a bit confusing, the master branch refers to next major (v6), but also deploys the website (which refers to v5) eventually both will be alinged when v6 is released, but at this point is like this. |
src/api/web/html/renderHTML.ts
Outdated
cache.set('template', webPage); | ||
if (needHtmlCache) { | ||
cache.set('template', webPage); | ||
} | ||
debug('set template cache'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include debug debug('set template cache');
within the if condition otherwise is missleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,I have committed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've took the liberty to apply some small changes, add suggestion to the config files and just moved your new line to the header of the function close to the other configs, maybe you can apply same change son the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great stuff @Tiny-Fendy it will be on next minor
Failed checks are unrelated with this changes. |
This is a new PR related to #3108.