Missing "onClick" prop in @verdaccio/ui-components Link component preventing handleDownload call in Package.tsx #3988 #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "Link" component, the onClick handler was not provided, leading to the absence of a download action in the Package.tsx renderDownloadLink component.
The "external" attribute is unnecessary in this context since the download action is triggered by the "handleDownload" callback.
1 task
|
Hey @juanpicado, |
|
It's fine a limitation of GitHub no table to share token with forks I will check later thanks ! |
|
Please add the changeset, check contribution guidelines how to do it otherwise I cannot rleease |
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, attempting to download the "tar" file from the Package List on the homepage does not work as expected. Clicking on the link only opens a new tab, but no download action occurs.
The root cause of this problem lies in the
LinkComponent within @verdaccio/ui-components. It lacks a necessaryonClickprop, preventing the execution of thehandleDownloadfunction inPackage.tsx.