Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not * match @*/*? #429

Closed
UnitedMarsupials-zz opened this issue Dec 7, 2017 · 5 comments
Closed

Should not * match @*/*? #429

UnitedMarsupials-zz opened this issue Dec 7, 2017 · 5 comments

Comments

@UnitedMarsupials-zz
Copy link
Contributor

My reason:

I configured the default uplink as documented:

uplinks:
  'npmjs':
    url: 'https://registry.npmjs.org/'
    cache: true

packages:
  '*':
    access: $all
    proxy: npmjs

This works for most stuff, but not for things like @types/node. To be able to process these, I had to add another entry to packages:

  '@*/*':
    access: $all
    proxy: npmjs

If that's intentional, I wonder, what the reasons are. If not, it needs fixing, no?

Application version:

2.7.0

@juanpicado
Copy link
Member

If you are moving from Sinopia that package configuration pretty likely does not exist. In Verdaccio is already built-in, you can see the configuration template here. https://github.com/verdaccio/verdaccio/blob/master/conf/full.yaml#L59

Why does not match? I'm not sure but the match is here https://github.com/verdaccio/verdaccio/blob/master/src/lib/config.js#L201

@UnitedMarsupials-zz
Copy link
Contributor Author

If you are moving from Sinopia that package configuration pretty likely does not exist.

Sorry, I do not understand the above sentence. Yes, I'm adapting the configuration file from that installed by Sinopia's Ansible-playbook.

Why does not match? I'm not sure but the match is here [...]

I see a function call on that line. What the function does is not immediately obvious. Should not "*" match everything?

@juanpicado
Copy link
Member

juanpicado commented Dec 9, 2017

I recall debugged such code long time ago when I was writing the documentation, also I noticed that, but tbh I do not remember the outcome of my debugging. There must be a reason, such code is the same from Sinopia AFAIK. (https://github.com/rlidwka/sinopia/blob/master/lib/config.js#L159)

@juanpicado
Copy link
Member

juanpicado commented Mar 15, 2018

The mystery is whether you do not include ** the app will do it for you. So, I recomend always include '**' .

http://www.verdaccio.org/docs/en/packages.html#blocking-proxying-a-set-of-specific-packages

@lock
Copy link

lock bot commented Jan 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants