Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from web section not longer valid properties #307

Closed
juanpicado opened this issue Aug 26, 2017 · 1 comment
Closed

Remove from web section not longer valid properties #307

juanpicado opened this issue Aug 26, 2017 · 1 comment

Comments

@juanpicado
Copy link
Member

My reason:

Update the web section on full.yalm due to not all properties are no longer valid.

web:
  enable: true
  title: Verdaccio
  logo: logo.png
  template: custom.hbs
  tagline: "Some <b>HTML</b> enabled tagline that sits between the actual \
                header and the list of packages. You can even add <a \
                href=\"https://github.com\">links</a>!"

template: was a way to use a custom template, but since we use a based React UI this property is not longer valid.
tagline: was a way to inject HTML, for the same reason as template is not longer valid.

Steps to reproduce:

web:
  template: custom.hbs
  tagline: "Some <b>HTML</b> enabled tagline that sits between the actual \
                header and the list of packages. You can even add <a \
                href=\"https://github.com\">links</a>!"

Those properties do not have any effect in the UI

App Version:

v2.3.6

@lock
Copy link

lock bot commented Jan 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants