Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxdrift fix / fork is implemented wrong #685

Closed
ocminer opened this issue Apr 5, 2018 · 5 comments
Closed

maxdrift fix / fork is implemented wrong #685

ocminer opened this issue Apr 5, 2018 · 5 comments
Labels
brainstorming thinking about possible solution sets and their advantages (keep discussing) testing lacks manual / automated tests of any kind

Comments

@ocminer
Copy link

ocminer commented Apr 5, 2018

Your second "fix".. Is still not working at all, the edit you have here:

https://github.com/vergecurrency/VERGE/blob/master/src/main.cpp#L2306-L2321

You also need here:

https://github.com/vergecurrency/VERGE/blob/master/src/main.cpp#L2219

One is for reading blocks from disk e.g. resyncing and the other is for accepting blocks via peers...

@justinvforvendetta
Copy link
Member

they shouldn't make it to disk if it isn't accepted from peers though

@justinvforvendetta
Copy link
Member

I'm on my phone right now but I'll look in a minute

@ocminer
Copy link
Author

ocminer commented Apr 5, 2018

but you still need to go through the old blockchain...

@justinvforvendetta
Copy link
Member

i see what you mean, thanks for the heads up. we're implementing more verifications, like making sure one algo cant be submitted too many times in a row, etc.. few more hardening features

@mlp
Copy link

mlp commented Apr 6, 2018

What is the multi-algo strategy supposed to be? Is is supposed to rotate algos between blocks?

@jrsikors jrsikors added brainstorming thinking about possible solution sets and their advantages (keep discussing) testing lacks manual / automated tests of any kind labels Apr 6, 2018
@jrsikors jrsikors closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming thinking about possible solution sets and their advantages (keep discussing) testing lacks manual / automated tests of any kind
Projects
None yet
Development

No branches or pull requests

4 participants