Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VbkBlock finalization check #980

Closed
4 tasks
Mr-Leshiy opened this issue Apr 12, 2022 · 1 comment
Closed
4 tasks

VbkBlock finalization check #980

Mr-Leshiy opened this issue Apr 12, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Mr-Leshiy
Copy link
Contributor

For VbkBlock need to add some kind of canFinalized() method which will return to us either can we finalize this block or not.

  • update VbkBlockAddon, add MerkleTree struct for the VbkPopTxs and fill it with the any new related transaction.
  • update VbkBlockAddon, add validation method which will be checked if all possible VbkPopTxs have been already added into the MerkleTree
  • update VbkBlockTree, payloads procedure with the filling this new MerkleTree field for the VbkBlockAddond
  • update VbkBlockTree finalization procedure with the usage of the new VbkBlockAddond validation method
@Mr-Leshiy Mr-Leshiy self-assigned this Apr 12, 2022
@Mr-Leshiy Mr-Leshiy added the enhancement New feature or request label Apr 12, 2022
@Mr-Leshiy
Copy link
Contributor Author

After a proper discussion with the @Warchant , decide to close this issue, because all these problems will be solved with the final VBK SPV implementation #983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant