Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant connect after first connection aborted #322

Closed
rsodre opened this issue May 2, 2023 · 2 comments · Fixed by #355
Closed

Cant connect after first connection aborted #322

rsodre opened this issue May 2, 2023 · 2 comments · Fixed by #355
Assignees
Labels
bug Something isn't working

Comments

@rsodre
Copy link

rsodre commented May 2, 2023

After upgrading to verida packages 2.3.4, when the user aborts a connection by clicking on the X instead of scanning the QR code, the subsequent connection attempts do not display the QR code and exit quietly.

@aurelticot aurelticot added the bug Something isn't working label Jun 28, 2023
@aurelticot
Copy link
Contributor

In WebUser, the connect function makes an early return if there's an existing connecting Promise.
In the case the user already triggered the connection but cancelled it, the connecting Promise will exist with a result false which will be returned to the consumer of WebUser without triggering a new connection.

@tahpot
Copy link
Contributor

tahpot commented Dec 12, 2023

Fixed with fa8081c

@tahpot tahpot mentioned this issue Dec 12, 2023
@aurelticot aurelticot linked a pull request Dec 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants