Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve graceful shutdown of controller reconcile loop #14

Closed
jlarfors opened this issue Mar 14, 2024 · 0 comments
Closed

Improve graceful shutdown of controller reconcile loop #14

jlarfors opened this issue Mar 14, 2024 · 0 comments

Comments

@jlarfors
Copy link
Contributor

Right now the reconcile loop happens in a Go routine, and there is nothing to block and wait for it to finish.

Reconcile loops do important stuff, so we should sit and wait for them to finish.

Implement something like a sync.WaitGroup in the ctlr.Stop() method, or similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlarfors