fix: configs in plugin declaration file #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
This also fixes the globals values of
env
config. It was previouslywriteable
but the correct iswritable
(all though I don't understand why it's specified as writable in the first place). This was not type checked previously since there are no type constraints withObject.assign
.Side note: I'm noticing that the CI pipeline don't typecheck the code.
pnpm tsc
fails on main for me.