Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crazy fetch bash-script #4

Closed
antonkulaga opened this issue Jun 29, 2020 · 0 comments
Closed

crazy fetch bash-script #4

antonkulaga opened this issue Jun 29, 2020 · 0 comments

Comments

@antonkulaga
Copy link
Contributor

I see you have really weird bash script that does:

# Cloning additional dependencies
git clone https://github.com/OpenMined/PyGrid.git
git clone https://github.com/OpenMined/PyGridNode.git
git clone https://github.com/OpenMined/PyGridNetwork.git

Why do you do git-clone inside bash script? If you want to use other git repos you should use Git Submodules. However, I do not get why it is even needed if you can use official docker containers?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonkulaga @vermasrijan