Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Create a separate component for the buttons/bpm menu #3

Closed
Vernalhav opened this issue Aug 23, 2020 · 0 comments
Closed

[Improvement] Create a separate component for the buttons/bpm menu #3

Vernalhav opened this issue Aug 23, 2020 · 0 comments
Assignees
@Vernalhav
Labels
improvement Refactoring, documentation improvements and minor tweaks

Comments

@Vernalhav
Copy link
Owner

Description:
The top container could be separated into its own component to reduce clutter in MainPage/index.tsx.

Current situation:
The top menu layout takes up the most space in the JSX representation of the main page. If it could be separated into its own component and communicate its events properly with the main page, it would be overall better to the codebase.
The element is the div with class "center-container" in the return value of MainPage.

Proposed solution:
This could probably be solved with custom events fired by the buttons/selector that the main page handles with dispatchEvent.
@Vernalhav Vernalhav added the improvement Refactoring, documentation improvements and minor tweaks label Aug 23, 2020
@Vernalhav Vernalhav self-assigned this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vernalhav Vernalhav

Labels
improvement Refactoring, documentation improvements and minor tweaks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vernalhav