Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vmq_server termination error #828

Closed
dergraf opened this issue Sep 11, 2018 · 1 comment
Closed

Fix vmq_server termination error #828

dergraf opened this issue Sep 11, 2018 · 1 comment
Assignees
Labels

Comments

@dergraf
Copy link
Contributor

dergraf commented Sep 11, 2018

When terminating vmq_server it will disable the metadata plugin. This doesn't work as a not existing vmq_plugin_mgr:disable_plugin/2 is called. This wasn't noticed as the exception was catched when the application controller was stopping the vmq_server application.

Changing the disable_plugin to the proper arity revealed another issue. While vmq_server is now able to disable the metadata plugin, the metadata plugin (itself an OTP application) has to be stopped by the application controller. However the application controller blocks until the vmq_server was properly terminated. Resulting in a deadlock when shutting down the vmq_server application.

The workaround that works is to terminate the metadata plugin in it's own process allowing the parent application:stop call to finish.

@larshesel
Copy link
Contributor

Was fixed in #829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants