Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would anyone like to take over ownership of this library? #43

Closed
jackmott opened this issue Jan 18, 2023 · 6 comments
Closed

Would anyone like to take over ownership of this library? #43

jackmott opened this issue Jan 18, 2023 · 6 comments

Comments

@jackmott
Copy link
Collaborator

I feel bad that I haven't had time to respond to any issues, if anyone has been playing with this that would like to become the maintainer, let me know.

@jackmott
Copy link
Collaborator Author

@arduano any interesting in taking this on and keeping it in sync with SIMDEEZ?

@arduano
Copy link

arduano commented Jan 23, 2023

Only if it's to keep it in sync. I currently have no use case for this library so it would be hard to develop it past basic maintenance.

@jackmott
Copy link
Collaborator Author

ok, I don't want to burden you, I'll see if I can keep it in sync or I have someone else in mind who might be interested.

@arduano
Copy link

arduano commented Jan 23, 2023

I could try to send a PR later when I further update simdeez, although I'll try avoiding major breaking changes in simdeez anyway (outside deprecations)

@verpeteren
Copy link
Owner

I will take over this library. I will close this issue.
@arduano : This library and simdeez are closely related, so we should indeed sync up.
@jackmott : thanks for the trust and all the work that you did!

@arduano
Copy link

arduano commented Jan 28, 2023

@verpeteren btw have you seen the changes I've been making on my current simdeez branch? There will potentially be a bit of work to sync this up without relying on deprecated functions (almost all of which I'll keep ofc).

In case you haven't seen, the idea is that:

  • The Simd trait no longer has any of the old functions on it (well, it still has all the old functions but they just proxy the new functions, and are marked as deprecated).
  • There are a lot more shared traits that describe the different behaviors of different vector types under different instruction sets.
  • The runtime generate macro now only generates 1 function, and that function automatically picks the best instruction set. Not exposing functions for other instruction sets allowed me to remove the "unsafe" attribute from almost all functions.
  • If you really need underlying instruction set access, you can get it with a feature flag in the crate, but exposing it also makes a bunch of operations unsafe again.

oh and also I've made a much more robust testing framework and caught a lot of undefined behavior and bugs in the old code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants