Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NackGenerator's member function still run after NackGenerator being deleted. #186

Closed
baiyufei opened this issue Jan 30, 2018 · 0 comments
Closed

Comments

@baiyufei
Copy link

https://github.com/versatica/mediasoup/blob/master/worker/src/RTC/NackGenerator.cpp#L112
This line may call NackGenerator's destructor.

AddPacketsToNackList(this->lastSeq + 1, seq);
RTC::RtpStreamRecv::OnNackGeneratorKeyFrameRequired()
RTC::RtpStreamRecv::RequestKeyFrame()
std::unique_ptr<RTC::NackGenerator, std::default_deleteRTC::NackGenerator >::reset(RTC::NackGenerator*)
RTC::NackGenerator::~NackGenerator()

https://github.com/versatica/mediasoup/blob/master/worker/src/RTC/NackGenerator.cpp#L116
This line accesses NackGenerator's nacklist(map), however nacklist has been broken.

https://github.com/versatica/mediasoup/blob/master/worker/src/RTC/NackGenerator.cpp#L262
This line can't return and causes 100% CPU usage in mediasoup-worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant