Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of typos #18

Closed
kfrp opened this issue May 28, 2020 · 1 comment
Closed

Couple of typos #18

kfrp opened this issue May 28, 2020 · 1 comment

Comments

@kfrp
Copy link

kfrp commented May 28, 2020

Thanks for this delightful lib! It was a breeze to set up and I'm looking forward to using it in everything.

I noticed a couple of small errors in the example code on https://protoojs.org:

The websocketserver example says

const server = new protooServer.WebSocketServer.Room(httpServer, options);

but there is no Room method; protooServer.WebSocketServer is the constructor.

The connectionrequest example should say await instead of async.

@ibc
Copy link
Member

ibc commented Jun 1, 2020

Thanks, done. Next time feel free to send a PR to https://github.com/versatica/protoo-website.

@ibc ibc closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants