Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make (glide install) fails #110

Closed
pete911 opened this issue Dec 13, 2017 · 1 comment · Fixed by #112
Closed

make (glide install) fails #110

pete911 opened this issue Dec 13, 2017 · 1 comment · Fixed by #112

Comments

@pete911
Copy link
Contributor

pete911 commented Dec 13, 2017 •
edited

glide.lock line 67 should have Sirupsen instead of sirupsen, see Should I use lowercase or uppercase for the package name and Rename back to Sirupsen/logrus

same with imports, it needs to match the repo, all imports need to be renamed to Sirupsen and Versent as well
@pete911 pete911 mentioned this issue Dec 13, 2017
Closed
@pete911
Copy link
Contributor Author

pete911 commented Dec 13, 2017

I have created pull request #111 , please have a look

wolfeidau added a commit that referenced this issue Dec 14, 2017
@wolfeidau
fix(Glide) Add logrus correctly to glide and track releases
0b22a15 
fixes #110
@wolfeidau wolfeidau mentioned this issue Dec 14, 2017
Merged
@wolfeidau wolfeidau mentioned this issue Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pete911