Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when using attribute heading #36

Closed
Michel73 opened this issue Feb 18, 2016 · 4 comments
Closed

Error occurs when using attribute heading #36

Michel73 opened this issue Feb 18, 2016 · 4 comments

Comments

@Michel73
Copy link

I got an error when I'm using the attribute heading in element uib-tab.

TypeError: Cannot read property 'textContent' of undefined
    at http://localhost:63342/scrolltabs/bower_components/angular-ui-tab-scroll/angular-ui-tab-scroll.js:297:92
    at Object.forEach (http://ajax.googleapis.com/ajax/libs/angularjs/1.4.9/angular.js:341:20)
    at Scope.link.$scope.reCalcAll (http://localhost:63342/scrolltabs/bower_components/angular-ui-tab-scroll/angular-ui-tab-scroll.js:291:27)

If I using the element uib-tab-heading instead it works.

@Shemesh
Copy link
Collaborator

Shemesh commented Feb 18, 2016

hi,
that is expected, since the change in ui bootstrap v0.14.0 a "uib" prefix was addded

http://angular-ui.github.io/bootstrap/versioned-docs/0.14.0/#/tabs
what is the issue?

@Michel73
Copy link
Author

The error occurs if I use:

<uib-tab heading="First tab">
        <div class="tabContent">First tab content</div>
</uib-tab>

The heading attribute is documented as an alternative to <uib-tab-heading>-tag.

Shemesh added a commit that referenced this issue Feb 20, 2016
take the tab header from a different place (align with tooltips).
@Shemesh
Copy link
Collaborator

Shemesh commented Feb 20, 2016

please see if the latest code solved this and let me know.

@Michel73
Copy link
Author

Ok, the latest code works for me.

@Shemesh Shemesh closed this as completed Feb 22, 2016
Shemesh added a commit that referenced this issue Feb 22, 2016
bug fix issue #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants