Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepalive messages for long running commands to prevent client timeouts #423

Closed
benmcclelland opened this issue Feb 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@benmcclelland
Copy link
Member

Describe the solution you'd like
Some commands like complete multipart upload can take a long time on some filesystems and possibly timeout on the client side. This causes the clients to have to set long timeouts for these commands to be successful.

We need to investigate if there are messages that can be sent back to the client periodically to let it know that the server is still processing the command.

@benmcclelland benmcclelland added the enhancement New feature or request label Feb 29, 2024
@jonaustin09
Copy link
Contributor

Request timeout is controlled by client side.
In case of aws CLI --cli-read-timeout flag is added to the actions(the default value is 60).
In case of aws SDKs:

ctx, cancel := context.WithTimeout(context.Background(), <timeout duration here>)
_, err := s3client.PutBucketAcl(ctx, &s3.PutBucketAclInput{
	Bucket: bucket,
})

Other SDKs also have their options to control request timeout.

@benmcclelland benmcclelland closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants