Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor s3api/utils into more meaningful sub package names #470

Open
benmcclelland opened this issue Mar 18, 2024 · 0 comments
Open

refactor s3api/utils into more meaningful sub package names #470

benmcclelland opened this issue Mar 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@benmcclelland
Copy link
Member

Describe the solution you'd like
See this post on why "utils" is not the best package name:
https://dave.cheney.net/2019/01/08/avoid-package-names-like-base-util-or-common

Additional context
We have in there:

  • auth-reader
  • chunk-reader
  • csum-reader
  • logger
  • presign-auth-reader
  • utils

We could probably split this up into sub packages of s3api that better stand on their own. Most of the functions in utils.go should probably just be moved to the calling package and unexported.

@benmcclelland benmcclelland added the enhancement New feature or request label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant