Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow us to use event bus with timeout for ruby (first fix) #28

Merged
merged 3 commits into from Apr 30, 2014
Merged

Allow us to use event bus with timeout for ruby (first fix) #28

merged 3 commits into from Apr 30, 2014

Conversation

gumyn
Copy link

@gumyn gumyn commented Mar 19, 2014

Fix issue : #27

ps : https://github.com/tinguelyp thanks for your help !

@pmarino90
Copy link
Contributor

@gumyn first of all thnx for you help :)
Then I have to ask you if you took a look at this: https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
about contributing, otherwise I think I cannot merge your commit!

@ddossot
Copy link
Contributor

ddossot commented Mar 31, 2014

@gumyn Any progress on this? This fix is really needed...

@gumyn
Copy link
Author

gumyn commented Apr 2, 2014

@pmarino90 What exactly blocks you to make the merge is it the signed-off story with eclipse ?

@pmarino90
Copy link
Contributor

yea if you can just have a look at it then I can merge your code, thank you!

gumyn added 3 commits April 2, 2014 10:02
Signed-off-by: gumyn <gumyn@MacBook-Pro-de-Gumy.local>
Signed-off-by: gumyn <gumyn@MacBook-Pro-de-Gumy.local>
@pmarino90 pmarino90 merged commit 2b8755f into vert-x:master Apr 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants