Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigRetrieverImpl calls getConfig() in its constructor #23

Closed
informedgut opened this issue Oct 19, 2017 · 3 comments
Closed

ConfigRetrieverImpl calls getConfig() in its constructor #23

informedgut opened this issue Oct 19, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@informedgut
Copy link

ConfigRetrieverImpl calls getConfig(), and with an empty handler at that. Clement agreed in the Google group that it should be taken out. Let the application call getConfig() explicitly.

Thanks!
Iggy

@informedgut
Copy link
Author

Oh while you're at it, and let me know if you'd prefer that I create a separate issue for this, please see if you can figure out a way to allow us to configure the Vertx object itself (VertxOptions) using properties from the config store(s). I had to jump through hoops to make it happen. It's the chicken-or-egg issue I refer to in the Google group. It needs a Vertx instance but I want the Vertx instance to use the config, too. I had to create two ConfigRetrievers - The first one does the retrieving using a temp Vertx object. Then, I create the final Vertx object and feed it into the second and final ConfigRetriever. This led me to filing this issue. I didn't want my second retriever to do another retrieve.

Not sure if there's a solution to this chicken-or-egg issue. But thought I'd bring it up.

@cescoffier
Copy link
Member

@informedgut yes, please create another issue for this. It's a tricky issue as the config retriever needs vertx. Are you looking for configuring vert.x itself or the verticle?

@cescoffier cescoffier added the bug label Oct 23, 2017
@cescoffier cescoffier self-assigned this Oct 23, 2017
@cescoffier cescoffier added this to the 3.5.1 milestone Oct 23, 2017
@informedgut
Copy link
Author

Thanks, Clement. Created issue #24 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants