Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to grpc-java 1.3.0 #6

Closed
ruslansennov opened this issue May 18, 2017 · 10 comments
Closed

Upgrade to grpc-java 1.3.0 #6

ruslansennov opened this issue May 18, 2017 · 10 comments

Comments

@ruslansennov
Copy link
Member

Is there any plans to bump version of GRPC to 1.3.0?

@vietj
Copy link
Contributor

vietj commented May 18, 2017

which netty version it depends on ?

@vietj
Copy link
Contributor

vietj commented May 18, 2017

I think that for 3.4.2 it might be a bit late, but we can try.

@ruslansennov
Copy link
Member Author

It requires 4.1.8-Final, exactly what we have.
See https://mvnrepository.com/artifact/io.grpc/grpc-netty/1.3.0

@vietj
Copy link
Contributor

vietj commented May 18, 2017

sounds trivial then, I know they cannot use 4.1.9-Final because there is a blocker issue in this version. can you try an upgrade and see how test go ?

@ruslansennov
Copy link
Member Author

can you try an upgrade and see how test go ?

sure

@ruslansennov
Copy link
Member Author

No, this is not trivial :) We should make new version of vertx-grpc-java-compiler before

@vietj
Copy link
Contributor

vietj commented May 18, 2017

can you open an issue in the project ?

@vietj
Copy link
Contributor

vietj commented May 18, 2017

I mean in vertx-grpc-java-compiler

@pmlopes
Copy link
Member

pmlopes commented May 19, 2017

the compiler has 2 pending PR requiring a release that provides releases 1.2.0 and 1.3.0 plugins. The changes are trivial which means that even if you use the old plugin with the new version you shouldn't see any big differences (a couple of classes that were public are now package protected).

So if you want to bump, just merge the PRs on the compiler side and release.

@vietj vietj changed the title io.grpc version Upgrade to grpc-java 1.3.0 May 19, 2017
@vietj vietj closed this as completed in b67fed0 May 19, 2017
@ruslansennov
Copy link
Member Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants