Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-length: 0 not accepted #84

Open
freynder opened this issue Apr 10, 2023 · 1 comment
Open

content-length: 0 not accepted #84

freynder opened this issue Apr 10, 2023 · 1 comment

Comments

@freynder
Copy link

Hi,

I'm testing a few payloads with krossbow STOMP client, and received an error on a SUBSCRIBE frame with content-length: 0 header:

13:03:45 [vert.x-eventloop-thread-1] ERROR io.vertx.core.impl.ContextBase - Unhandled exception 
java.lang.IllegalArgumentException: Size must be > 0
	at io.vertx.core.impl.Arguments.require(Arguments.java:29)
	at io.vertx.core.parsetools.impl.RecordParserImpl.fixedSizeMode(RecordParserImpl.java:156)
	at io.vertx.ext.stomp.impl.FrameParser.handleLine(FrameParser.java:113)
	at io.vertx.core.parsetools.impl.RecordParserImpl.handleParsing(RecordParserImpl.java:214)

The STOMP specification does not prohibit 0 values as far as I can see, so would be good to not enforce it.
(Note that the same client was previously used with a Spring Boot implementation with no issue).

Thanks

@freynder freynder added the bug label Apr 10, 2023
@vietj vietj added this to the 4.4.2 milestone Apr 11, 2023
@freynder
Copy link
Author

#86 includes a fix for this.

@vietj vietj modified the milestones: 4.4.2, 4.4.3 May 12, 2023
@vietj vietj modified the milestones: 4.4.3, 4.4.4-SNAPSHOT, 4.4.4 Jun 7, 2023
@vietj vietj modified the milestones: 4.4.4, 4.4.5 Jun 22, 2023
@vietj vietj modified the milestones: 4.4.5, 4.4.6 Aug 30, 2023
@vietj vietj modified the milestones: 4.4.6, 4.5.0 Sep 12, 2023
@vietj vietj modified the milestones: 4.5.0, 4.5.1 Nov 15, 2023
@vietj vietj modified the milestones: 4.5.1, 4.5.2 Dec 13, 2023
@vietj vietj modified the milestones: 4.5.2, 4.5.3 Jan 30, 2024
@vietj vietj modified the milestones: 4.5.3, 4.5.4 Feb 6, 2024
@vietj vietj modified the milestones: 4.5.4, 4.5.5 Feb 22, 2024
@vietj vietj modified the milestones: 4.5.5, 4.5.6 Mar 14, 2024
@vietj vietj modified the milestones: 4.5.6, 4.5.7 Mar 21, 2024
@vietj vietj modified the milestones: 4.5.7, 4.5.8 Mar 27, 2024
@vietj vietj modified the milestones: 4.5.8, 4.5.9 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants