Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenAPI 3.1.0 with RouterBuilder #2424

Closed
skuby2 opened this issue May 17, 2023 · 3 comments
Closed

Support for OpenAPI 3.1.0 with RouterBuilder #2424

skuby2 opened this issue May 17, 2023 · 3 comments
Assignees
Labels

Comments

@skuby2
Copy link

skuby2 commented May 17, 2023

Version

Which version(s) did you encounter this bug ?

4.4.1 and 4.4.2

Steps to reproduce

  1. Create an OpenAPI 3.1.0 document.
  2. Use RouterBuilder.create(...).
  3. This exception will be thrown during vertical start:
Caused by: io.vertx.json.schema.common.ValidationExceptionImpl: provided string should respect pattern ^3\.0\.\d(-.+)?$
	at io.vertx.json.schema.ValidationException.create(ValidationException.java:85)
	at io.vertx.json.schema.common.PatternValidatorFactory$PatternValidator.validateSync(PatternValidatorFactory.java:55)
	at io.vertx.json.schema.common.SchemaImpl.runSyncValidator(SchemaImpl.java:193)
	at io.vertx.json.schema.common.SchemaImpl.validateSync(SchemaImpl.java:128)
	at io.vertx.json.schema.common.PropertiesValidatorFactory$PropertiesValidator.validateAsync(PropertiesValidatorFactory.java:166)
	at io.vertx.json.schema.common.SchemaImpl.runAsyncValidators(SchemaImpl.java:173)
	at io.vertx.json.schema.common.SchemaImpl.validateAsync(SchemaImpl.java:121)
	at io.vertx.json.schema.common.SchemaImpl.validateAsync(SchemaImpl.java:48)
	at io.vertx.ext.web.openapi.impl.OpenAPIHolderImpl.lambda$loadOpenAPI$2(OpenAPIHolderImpl.java:88)
	at io.vertx.core.impl.future.Composition.onSuccess(Composition.java:38)
	... 22 common frames omitted

Listing this as a bug since #1872 was included in the 4.4.1 release.

@pk-work
Copy link
Contributor

pk-work commented Feb 20, 2024

Hi, there is a complete new rebuild of the OpenAPI Router [1], which also now also supports 3.1. Please check out if this works for you.

[1] https://vertx.io/docs/vertx-web-openapi-router/java/

@pk-work pk-work self-assigned this Feb 20, 2024
@stempler
Copy link

stempler commented Apr 18, 2024

Hi, there is a complete new rebuild of the OpenAPI Router [1], which also now also supports 3.1. Please check out if this works for you.

Does this mean the web-openapi module is deprecated? Or are there two competing implementations?

Update: I see vertx-web-openapi is not present any more in the master branch, so it seems it is removed. I guess then the issue can be closed?

@pk-work
Copy link
Contributor

pk-work commented Apr 22, 2024

Sorry, for the long delay. Yes it is deprecated.

@pk-work pk-work closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants