When the WebSocket connection is closed, the registrations is not clear!

[wjw465150]

Questions

I Found When the WebSocket connection is closed, the registrations is not clear

Version

Vert.x 4.4.4

Problem Code

In io.vertx.ext.web.handler.sockjs.impl.EventBusBridgeImpl class method clearSocketState,The registrations was not clear after the eventbus consumer was unregister!

Solution

after eventbus consumer was unregister,add registrations.clear();

[tsegismont]

I don't believe this is a problem, the map and its entries should be collected after the SockJS socket is closed.

Can demonstrate a leak with a reproducer?

[wjw465150]

Isn't it good to proactively close and release resources in a timely manner?

[tsegismont]

The resources (message consumers) are closed and released.

What you are talking about is removing references from the map instance to its entries, which are both going to be gc-ed later anyway.

I'm closing the issue but if there's an actual leak which can be demonstrated with a reproducer, feel free to reopen with all the details.