Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling %2F ('/') in route pattern matches. #259

Closed
bckfnn opened this issue Nov 18, 2015 · 0 comments
Closed

handling %2F ('/') in route pattern matches. #259

bckfnn opened this issue Nov 18, 2015 · 0 comments
Assignees
@pmlopes
Labels
bug

Comments

@bckfnn
Copy link

bckfnn commented Nov 18, 2015

The fix for #187 is IMO a bit too harsh.

It should be possible to issue a request like

GET /demo/Hello%2FWorld!

and get back the decoded value "Hello/World!"

A usecase would be sending an encoded url as param;

GET /demo/http%3A%2F%2Fwww.google.com

The whole path should not be decoded before matching, but the individual params should be decoded before they are returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmlopes pmlopes

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmlopes @bckfnn