Installation of EventBusBridgeHook missing within SockJSHandlerImpl

[leolux]

At SockJSHandlerImpl line 92 the EventBusBridgeHook does not get installed into the EventBusBridgeImpl, so the hook within SockJSHandlerImpl is useless.
Solution: Either call the method EventBusBrodgeImpl.setHook(this.hook) or create another constructor for the EventBusBridgeImpl and pass it to the constructor when creating the instance.

[purplefox]

I was thinking of removing the eventbusbridgehook. Can you explain your use case and why it is useful to you?

[leolux]

I am still within the design phase of my project, but here are some ideas I thought could be implemented by a hook:
a) Check the country of the client and reject them based on a ip->country mapping service
b) Prevent too many requests of a client within a time-frame by counting requests by sessionId (apexSession?)
c) Collect some statistics about the client browser agent

[purplefox]

I think all of those should be doable using standard Apex handlers?

[leolux]

Yes, you are right. The RoutingContext has everything inside which is need for implementing that. Today I discovered "routingContext.next()" in the apex docs. It seems that apex handles can be chained this way? Anyway, I do agree removing the hook.

[purplefox]

OK, let me know how it goes :)

[leolux]

Well, I can't use standard Apex handlers to count incoming websocket frames. The standard handlers will not be invoked for websocket communication happening after the protocol upgrade.

What I need is some interceptor that gets invoked on every incoming frame.