Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventBus bridge websocket transport should send meaningful status code when closing #804

Closed
vietj opened this issue Jan 16, 2018 · 4 comments
Closed

EventBus bridge websocket transport should send meaningful status code when closing #804

vietj opened this issue Jan 16, 2018 · 4 comments
Labels
enhancement help wanted

Comments

@vietj
Copy link
Contributor

vietj commented Jan 16, 2018

Currently the EventBus bridge websocket transport sends a close frame with a 1000 status code (normal closure).

When the transport is closed for a specific reason (invalid protocol, timeout), the socket should be closed with the appropriate status code.
@vietj
Copy link
Contributor Author

vietj commented Jan 16, 2018

Depends on eclipse-vertx/vert.x#2276

@slinkydeveloper
Copy link
Member

I will give a look

This was referenced Jan 18, 2018
Closed
Merged
@lalitjeevanrao
Copy link

@slinkydeveloper Guess this issue is resolved. @vietj shouldnt this issue be closed?

@vietj
Copy link
Contributor Author

vietj commented Nov 6, 2018

correct

@vietj vietj closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vietj @slinkydeveloper @lalitjeevanrao