fix review

apache · Aug 3, 2022 · 5415bcf · 5415bcf
1 parent 118fdf2
commit 5415bcf
Show file tree

Hide file tree

Showing 4 changed files with 744 additions and 116 deletions.
diff --git a/...-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/MySqlValidator.java b/...-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/MySqlValidator.java
@@ -67,8 +67,7 @@ public void validate() {
             } else {
                 // for the legacy source
                 connection =
-                        DebeziumUtils.createMySqlConnection(
-                                from(dbzProperties), sourceConfig.getJdbcProperties());
+                        DebeziumUtils.createMySqlConnection(from(dbzProperties), new Properties());
             }
             checkVersion(connection);
             checkBinlogFormat(connection);

diff --git a/...or-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/DebeziumUtils.java b/...or-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/DebeziumUtils.java
@@ -24,7 +24,6 @@
 import com.ververica.cdc.connectors.mysql.source.offset.BinlogOffset;
 import io.debezium.config.Configuration;
 import io.debezium.connector.mysql.MySqlConnection;
-import io.debezium.connector.mysql.MySqlConnectionWithJdbcProperties;
 import io.debezium.connector.mysql.MySqlConnectorConfig;
 import io.debezium.connector.mysql.MySqlDatabaseSchema;
 import io.debezium.connector.mysql.MySqlSystemVariables;
@@ -76,9 +75,8 @@ public static MySqlConnection createMySqlConnection(MySqlSourceConfig sourceConf
     /** Creates a new {@link MySqlConnection}, but not open the connection. */
     public static MySqlConnection createMySqlConnection(
             Configuration dbzConfiguration, Properties jdbcProperties) {
-        return new MySqlConnectionWithJdbcProperties(
-                new MySqlConnectionWithJdbcProperties.MySqlConnectionConfigurationWithCustomUrl(
-                        dbzConfiguration, jdbcProperties));
+        return new MySqlConnection(
+                new MySqlConnection.MySqlConnectionConfiguration(dbzConfiguration, jdbcProperties));
     }
 
     /** Creates a new {@link BinaryLogClient} for consuming mysql binlog. */