Fix ArrayedData WRT an empty binary

verypossible-labs · Apr 10, 2019 · b2ce507 · b2ce507
1 parent ed29a3e
commit b2ce507
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/harald/hci/arrayed_data.ex b/lib/harald/hci/arrayed_data.ex
@@ -60,6 +60,10 @@ defmodule Harald.HCI.ArrayedData do
   @doc """
   Deserializes the binary representation of a list of structs according to `schema`.
   """
+  def deserialize(schema, length, struct_module, bin)
+
+  def deserialize(_, length, _, <<>>) when length > 0, do: {:error, :incomplete}
+
   def deserialize(schema, length, struct_module, bin) do
     schema
     |> deserialize(bin, %{

diff --git a/test/harald/hci/arrayed_data_test.exs b/test/harald/hci/arrayed_data_test.exs
@@ -0,0 +1,12 @@
+defmodule Harald.HCI.ArrayedDataTest do
+  use ExUnit.Case, async: true
+  alias Harald.HCI.{ArrayedData, Event.LEMeta.AdvertisingReport.Device}
+
+  doctest ArrayedData, import: true
+
+  describe "deserialize/4" do
+    test "an empty binary results in an error" do
+      assert {:error, :incomplete} == ArrayedData.deserialize([], 1, Device, <<>>)
+    end
+  end
+end