Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase data structures handled by scans #39

Merged
merged 1 commit into from
May 27, 2019

Conversation

danielspofford
Copy link
Contributor

Resolves #36.

This was achieved by ensuring that when deserializing advertising
reports, portions of the binary that cannot be deserialized should not
cause a chain reaction of failure. Previously this would cause devices
not to show up in the results.

  • ArrayedData: return an error instead of crashing
  • AdvertisingReport: use the result of Device.deserialize regardless of
    status
  • Device
    • cleanup bad doctests
    • simplify some serialization clauses to ensure the input binary is
      returned on error
  • Transport
    • improve documentation
    • LE is always a handler

This was achieved by ensuring that when deserializing advertising
reports, portions of the binary that cannot be deserialized should not
cause a chain reaction of failure. Previously this would cause devices
not to show up in the results.

- ArrayedData: return an error instead of crashing
- AdvertisingReport: use the result of Device.deserialize regardless of
  status
- Device
  - cleanup bad doctests
  - simplify some serialization clauses to ensure the input binary is
    returned on error
- Transport
  - improve documentation
  - LE is always a handler
@danielspofford danielspofford merged commit 8619343 into master May 27, 2019
@danielspofford danielspofford deleted the advertising-report branch May 27, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled AD Structures should not prevent an advertising report from being returned from a scan
1 participant