Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodBoundaryAspect cannot be used in dotnet standard with default NuGet restore #47

Closed
clawrenceks opened this issue Sep 13, 2018 · 4 comments
Labels

Comments

@clawrenceks
Copy link

The behaviour I am describing below is something that I have seen in both .net core 2.0 applications and .net standard 2.0 class libraries.

When installing the MethodBoundaryAspect.Fody package, from the UI or command line tools, the library is not immediately usable without manual package configuration. This is demonstrated below. I can not see any documentation regarding this anywhere, is this intended behaviour? Or does the 'fix' described below have any undesired side effect?

After installing the NuGet package the entry in .csproj will look as follows:

<PackageReference Include="MethodBoundaryAspect.Fody" Version="1.0.66">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

With the package configured as follows, the library is unusable as it is not detected by the compiler - see screenshot below.

image

To resolve the issue I change the csproj package reference to the following and all works again.

<PackageReference Include="MethodBoundaryAspect.Fody" Version="1.0.66" />
@cpwood
Copy link

cpwood commented Sep 15, 2018

Same here, but hat tip to @clawrenceks for the workaround!

@mfe-
Copy link

mfe- commented Oct 24, 2018

This should be added to the install guid! Thanks

@marcells
Copy link
Contributor

Uh, thanks for the information. 👍 We will investigate that issue. If you have a solution for it (beside documentation) let us know it.

@marcells marcells added the bug label Oct 24, 2018
@Martinay
Copy link
Contributor

Martinay commented Jan 7, 2019

should be fixed with version 2.0.104. If the issue still occures please reopen this bug or create a new one.

@Martinay Martinay closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants