Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove ownership from commits #10

Closed
heyhippari opened this issue Mar 24, 2020 · 1 comment
Closed

Don't remove ownership from commits #10

heyhippari opened this issue Mar 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@heyhippari
Copy link
Contributor

There are no issues with cherry-picking commits to your fork, it's what open source and free software is about.

However, when doing so, you NEED to keep ownership and history. Indeed, the GPL (the license under which the code is in) grants copyright to each contributor for their code.

By breaking authorship, such as with this commit: 8081595 (Which is a copy of this Jellyfin commit: jellyfin/jellyfin@2c8592f ) you are essentially stealing the work of someone else and breaking their copyright.

In order to be GPL compliant, you need to properly cherry-pick whatever commits you wish to implement instead of redoing an identical commit with someone else's work.

If you need help, here's an article that explains what to do: https://www.previousnext.com.au/blog/intro-cherry-picking-git

@heyhippari heyhippari added the bug Something isn't working label Mar 24, 2020
@aivit
Copy link
Collaborator

aivit commented Mar 24, 2020

Thanks for the link. I've bookmarked it.

@aivit aivit closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants