Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow document GC starves moving buckets to ideal nodes #4165

Closed
vekterli opened this issue Nov 16, 2017 · 0 comments · Fixed by #4168
Closed

Slow document GC starves moving buckets to ideal nodes #4165

vekterli opened this issue Nov 16, 2017 · 0 comments · Fixed by #4168
Assignees
Milestone

Comments

@vekterli
Copy link
Member

Maintenance operations are generated with a fixed internal priority depending on their assumed importance. An operation's priority affects how many of its type may be pending at any given point in time. Higher priority operations, if present, effectively pre-empt lower priority operations.

Currently, bucket GC has priority LOW, while a move-only merge has priority VERY_LOW. This means that if a cluster is falling behind on its GC duties (usually due to a too short configured GC period or an expensive GC expression), move-only merges will end up being entirely preempted. This can cause stalls in moving documents away from retired nodes and/or onto a newly introduced node.

I'm tempted to either flip the two priorities, or bring GC down to VERY_LOW.

vekterli added a commit that referenced this issue Nov 16, 2017
Having GC be higher priority than move-only merges meant that slow GC
could effectively inhibit node retirement. Furthermore, move-only merges
are finite while GC happens indefinitely, so it makes sense to give merging
higher priority overall.

This fixes #4165
@geirst geirst added this to the soon milestone Jan 10, 2018
@geirst geirst added this to In Progress in Search and content Jan 10, 2018
@geirst geirst moved this from In Progress to Done in Search and content Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants