Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default options for generate_supervisor.py #11

Closed
o7n opened this issue Oct 29, 2018 · 2 comments
Closed

default options for generate_supervisor.py #11

o7n opened this issue Oct 29, 2018 · 2 comments
Labels

Comments

@o7n
Copy link

o7n commented Oct 29, 2018

Disclaimer: I'm not really familiar with Django, so there might be something version related.
This is on a clean CentOS 7.5 box.

An incorrect supervisord.conf was being generated - it turns out there is an issue with the default value of the omitted source parameter for generate_supervisor.py

This source = options.get('source', '/opt/vespene/') is not working - source becomes None

This does work:

parser.add_argument('--source', type=str, help='source', default='/opt/vespene/')
..
source = options.get('source')

Edit: (I see you just fixed this by adding the source= parameter while I was typing this message).

@mpdehaan
Copy link
Member

Yes, you're 100% correct, I just pushed a change to the setup script to add the "--source", this is apparently me forgetting to check in an update earlier.

I need to modify the code still to set a default.

If you install from master now (update /opt/vespene) it will be good to go, but I'm leaving this ticket open so I remember to set the default in the source.

Thanks!

@mpdehaan mpdehaan added the t=bug label Oct 30, 2018
@mpdehaan
Copy link
Member

Should be all fixed now, thanks again!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants