Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippings Cart #11

Closed
ric2016 opened this issue Apr 19, 2020 · 2 comments
Closed

Clippings Cart #11

ric2016 opened this issue Apr 19, 2020 · 2 comments

Comments

@ric2016
Copy link
Contributor

ric2016 commented Apr 19, 2020

"wenn ich eine Person in die Clipping-cart eingebe, wird der "3 _LOC @x2@"-tag nicht gespeichert, und man kann auch kein Shared-place in die Clipping-cart hinzufügen."

@ric2016
Copy link
Contributor Author

ric2016 commented Apr 25, 2020

Required adjustments:

  • ClippingsCartModule.getMenu() (in order to add a shared place directly (cf. ROUTES_WITH_RECORDS))

  • ClippingsCartModule.addRecordToCart() ("Add directly linked media, notes, repositories and sources.": also add directly linked shared places)

Clean impl requires a separate Vesta Clipping Cart module, with hooks for shared places.
Note: It is questionable whether shared places linked indirectly via name should be added as well.

@ric2016
Copy link
Contributor Author

ric2016 commented May 9, 2020

Clippings Cart now available as a separate module: https://github.com/vesta-webtrees-2-custom-modules/vesta_clippings_cart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant