Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vesta-place-list: no 'shared places' after import #127

Closed
ungeahnt opened this issue May 29, 2022 · 5 comments
Closed

vesta-place-list: no 'shared places' after import #127

ungeahnt opened this issue May 29, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@ungeahnt
Copy link

I'm testing your suggestions from #126.

For this, I've created a new test tree and I've exported my complete main pedigree (with all _LOC-data) as GEDCOM-file and imported it in the new test tree. No single manual change from myself.

But when I open "Place hierarchy" and select "restrict to shared places" in the test tree (=imported data), then I see no single shared places. What's wrong?

@ungeahnt
Copy link
Author

ungeahnt commented May 29, 2022

forgotten to say: when I export the test tree and make a diff with the import file, then the GEDCOM-files differ only in two lines (TIME and FILE) and I can see the all the _LOC entries ([edit] I cann see the _LOC data only in the external editor, not in wt).

@ric2016
Copy link
Contributor

ric2016 commented May 29, 2022

I can reproduce this.

It's not only an issue when selecting 'restrict to shared places': Note that the shared place icons are also missing in the place list. So it's probably not caused by my latest changes, but a general problem related to importing a tree. Anyway I'll have to investigate.

@ric2016 ric2016 added the bug Something isn't working label May 29, 2022
@ric2016
Copy link
Contributor

ric2016 commented May 29, 2022

It's a caching issue.
Workaround is to delete the "webtrees\data\cache" folder, and open the shared place list once.
Afterwards, the place hierarchy list also works as expected.
Proper fix to follow.

@ric2016 ric2016 reopened this May 29, 2022
@ric2016
Copy link
Contributor

ric2016 commented May 29, 2022

Fixed in latest release 2.1.4.1.1.
Note that after importing a tree, you still have to load all shared places once (via opening the shared places list) in order to have proper placelinks in the place hierarchy.

(this should ultimately be improved as well but is a bit tricky, as the solution will have to adjust the webtrees import/update methods)

@ric2016 ric2016 closed this as completed May 29, 2022
@ungeahnt
Copy link
Author

you still have to load all shared places once (via opening the shared places list)

I've updated with e53cc9a and with the manual reload via 'shared places list' (but not via 'Place hierarchy') it works.

Thanks for the quick reply and solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants